Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: synchronize text from CLI for subcommands #311

Closed
wants to merge 1 commit into from
Closed

chore: synchronize text from CLI for subcommands #311

wants to merge 1 commit into from

Conversation

TerryHowe
Copy link
Member

@TerryHowe TerryHowe commented May 19, 2024 •
edited
Loading

Partial: #287

sabre1041
sabre1041 previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou added the duplicate This issue or pull request already exists label May 29, 2024
sajayantony
sajayantony reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@sajayantony sajayantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can take in #319 which has these changes.

@FeynmanZhou
Copy link
Member

We agreed to close this PR as #319 has included the similar changes

@TerryHowe
Copy link
Member Author

Rebased to validate there was nothing here

@TerryHowe TerryHowe closed this May 29, 2024
TerryHowe
TerryHowe commented May 29, 2024
View reviewed changes
docs/commands/oras_manifest_fetch.mdx
@@ -1,6 +1,6 @@
---
title: oras manifest fetch
sidebar_position: 110
sidebar_position: 150
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume I selected the wrong weight in my rebase, but either way, weights are generated and will self correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajayantony sajayantony sajayantony left review comments

@sabre1041 sabre1041 sabre1041 left review comments

@asmitbm asmitbm Awaiting requested review from asmitbm asmitbm is a code owner

@FeynmanZhou FeynmanZhou Awaiting requested review from FeynmanZhou FeynmanZhou is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@vsoch vsoch Awaiting requested review from vsoch vsoch is a code owner

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TerryHowe @FeynmanZhou @sabre1041 @sajayantony